Skip to content

Conversation

Timeless0911
Copy link
Contributor

Summary

Support using shorter string value of output.distPath as dts emit path.

Related Links

web-infra-dev/rsbuild#6352

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 10:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for using the shorter string value of output.distPath as the dts emit path, in addition to the existing output.distPath.root option.

  • Enhanced dts path resolution to support both string and object forms of output.distPath
  • Updated documentation to reflect the new priority order
  • Modified error messages to reference the updated configuration options

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/plugin-dts/src/index.ts Added logic to handle both string and object forms of output.distPath
packages/plugin-dts/src/utils.ts Updated function parameter name and comment to reflect new priority order
packages/plugin-dts/src/dts.ts Updated error message to reference output.distPath instead of output.distPath.root
website/docs/zh/guide/advanced/dts.mdx Updated Chinese documentation to include both configuration options
website/docs/zh/config/lib/dts.mdx Updated Chinese configuration documentation for priority order
website/docs/en/guide/advanced/dts.mdx Updated English documentation to include both configuration options
website/docs/en/config/lib/dts.mdx Updated English configuration documentation for priority order
packages/plugin-dts/README.md Updated README to reflect the new priority order

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit f9e0d1d
🔍 Latest deploy log https://app.netlify.com/projects/rslib/deploys/68ef7518dee65f0008658c2e
😎 Deploy Preview https://deploy-preview-1269--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fi3ework fi3ework merged commit 59c6e8b into main Oct 15, 2025
15 checks passed
@fi3ework fi3ework deleted the root branch October 15, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants